-
Notifications
You must be signed in to change notification settings - Fork 294
fix: product visuals and footer layout on mobile viewport #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Change product visuals grid to responsive (1 col mobile, 2 col tablet+) - Wrap footer components in div with padding for mobile - Add padding to header, main, and footer-wrapper on mobile - Reset container padding to 0 on mobile viewports Fixes appwrite#2580
WalkthroughThis change modifies the layout of a single Svelte page component. The product visuals grid was reconfigured to display as single-column on all viewports, with responsive two-column layout on small screens. Additionally, the footer elements (FooterNav and MainFooter) were grouped within a new wrapper div. The styling was updated to include responsive padding for the new footer wrapper element within the media query rules. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@AbhiVarde thanks! :) @HarshMN2345 could you review this? |
|
Thank you, @sara-k-48 ma’am! 🙏 |
What does this PR do?
Problem
The assets page had two layout issues on mobile viewports:
Solution
Product visuals: Changed grid from
grid-cols-2togrid-cols-1 sm:grid-cols-2for responsive layout.Footer: Wrapped footer components in a div and added padding via CSS media query to match other pages.
Changes Made
File:
src/routes/assets/+page.svelteTest Plan
Screenshots
Product Visuals (Before ):
Product Visuals (After ):
Footer (Before ):
Footer (After ):
Related PRs and Issues
Fixes #2580
Have you read the Contributing Guidelines on issues?
Yes, I have read and followed the contributing guidelines.
Summary by CodeRabbit