Settings feature branch

[UserNotFound]

• aptible_app gains docker_image, private_registry_username, private_registry_password as top-level attributes
• aptible_endpoint gains 9 new settings attributes (force_ssl, idle_timeout, maintenance_page_url, etc.) with per-endpoint-type validation
• Migrates aptible_app create/update to use the newer aptibleapi client
• Adds convergence testing (plan-after-apply, plan-after-import) across all test cases

Replaces and builds upon the previous PR's, that just had settings/senstive_settings maps:

• [SC-36041] App settings #162
• [SC-36039] Vhost settings #160

Note: to test this properly, you will have to set_stack_settings Stack.where(name: 'sbx-settings'), { 'sweetness/nonsensitive/SETTINGS_MIGRATION_PHASE' => '1' }, which I have already done on sbx-settings.

Terraform accectance test
Cloning into 'terraform-provider-aptible'...
remote: Enumerating objects: 1331, done.
remote: Counting objects: 100% (633/633), done.
remote: Compressing objects: 100% (285/285), done.
remote: Total 1331 (delta 523), reused 374 (delta 348), pack-reused 698 (from 3)
Receiving objects: 100% (1331/1331), 823.02 KiB | 5.31 MiB/s, done.
Resolving deltas: 100% (897/897), done.
Switched to a new branch 'settings-feature-branch'
Branch 'settings-feature-branch' set up to track remote branch 'settings-feature-branch' from 'origin'.
Testing branch settings-feature-branch at ec7ef2be1f05201648fee9818ffd3fde99a875a7
...

ok  	github.com/aptible/terraform-provider-aptible/aptible	1111.775s
  passes the terraform acceptance suite

Finished in 19 minutes 55 seconds (files took 1.38 seconds to load)
1 example, 0 failures

[promptless]

Promptless prepared a documentation update related to this change.

Triggered by PR #174 (Settings feature branch)

This PR consolidates the Settings feature work from PRs #160 and #162. The documentation update covers the new app deployment attributes (docker_image, private_registry_username, private_registry_password) and endpoint settings configuration.

Review: Document Terraform provider app and endpoint settings attributes

[UserNotFound]

https://app.shortcut.com/aptible/story/36041/add-app-settings-to-tf

[UserNotFound]

https://app.shortcut.com/aptible/story/36039/implement-vhost-settings-in-tf-provider

[madhuravius]

from a code perspective - i have mainly minor requests/nits. feel free to disagree with them

i need to talk to you about one file in particular aptible/resource_endpoint.go. there's a lot of object => map => object stuff going on and i'm not 100% sure why, is it because of client issues or v1/v2 compat (or something ELSE?)

either way let me know. i'm testing the functionality of it now

[madhuravius]

The only items remaining are:

• low impact reduce repetition/exhaustiveness of if/else chain with appending errors
• preference to add prematurely optimized functions (but you could argue it's clearer to have it broken up this way)

LMK if you feel strongly the other way about the above two and happy to approve (i recommend doing it though just in case). This + integration tests make me feel pretty good about this as that seems exhaustive enough.

The only other potential thing I can think of is folks who might get impacted by state migration/update issues. Ex: existing users on OLDER versions of terraform with settings now moving to NEWER versions may have broken terraform and/or state. I can help test this out and verify.

[UserNotFound]

Ready for another look!

[madhuravius]

LGTM - thanks for addressing the feedback