Simulate as anyone #15866
Open
Simulate as anyone #15866
+556
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been naming it "Ubuntu", when we should just call it Linux, and let people deal with mismatched GlibC and OpenSSL. Additionally, add back MacOS for ARM and for x86.
|
⏱️ 7s total CI duration on this PR
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| // Warn local user that clock is skewed behind the blockchain. | ||
| // There will always be a little lag from real time to blockchain time | ||
| if now_usecs < state.timestamp_usecs - ACCEPTED_CLOCK_SKEW_US { | ||
| eprintln!("Local clock is is skewed from blockchain clock. Clock is more than {} seconds behind the blockchain {}", ACCEPTED_CLOCK_SKEW_US, state.timestamp_usecs / US_IN_SECS ); |
There was a problem hiding this comment.
There is a duplicate "is" in the error message: "Local clock is is skewed". Consider updating to "Local clock is skewed" for better readability.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist