-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Consensus Observer] Add ObservedOrderedBlock to various stores. #15892
Open
JoshLind
wants to merge
3
commits into
co_exec_pool2
Choose a base branch
from
co_exec_pool3
base: co_exec_pool2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+388
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 45m total CI duration on this PR
|
JoshLind
force-pushed
the
co_exec_pool3
branch
from
February 5, 2025 21:17
d14fca6
to
ac7a415
Compare
JoshLind
force-pushed
the
co_exec_pool3
branch
from
February 6, 2025 03:36
decd111
to
fd55929
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
changed the title
[Consensus Observer] Add ObservedOrderedBlock to pending block store.
[Consensus Observer] Add ObservedOrderedBlock to various stores.
Feb 6, 2025
JoshLind
force-pushed
the
co_exec_pool3
branch
from
February 6, 2025 14:26
fd55929
to
1b11876
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
co_exec_pool3
branch
3 times, most recently
from
February 6, 2025 15:19
e9dcf63
to
d45756e
Compare
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
co_exec_pool3
branch
from
February 6, 2025 15:41
d45756e
to
1537252
Compare
JoshLind
requested review from
zekun000,
sasha8 and
ibalajiarun
as code owners
February 6, 2025 15:55
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JoshLind
force-pushed
the
co_exec_pool3
branch
from
February 6, 2025 17:17
1537252
to
3197ade
Compare
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is built on: #15869
Description
This PR adds a new
ObservedOrderedBlock
wrapper to consensus observer, with skeleton code. This supports self-contained ordered blocks, and blocks with windows (for execution pool).The PR offers the following commits:
ObservedOrderedBlock
type, and integrate it into the pending block store.ObservedOrderedBlock
to the ordered block store.In the next PR, I'll work on the window dependency traversal logic, and start working on the new buffering and clearing logic.
Testing Plan
New and existing test infrastructure.