add move script for reducing voting threshold #15910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 21m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
sherry-x
force-pushed
the
update-governance-threshold
branch
2 times, most recently
from
a61cd82 to
3615784
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| aptos_governance::get_required_proposer_stake(), | ||
| aptos_governance::get_voting_duration_secs(), | ||
| ); | ||
| aptos_governance::reconfigure(framework_signer); |
There was a problem hiding this comment.
The framework_signer parameter is borrowed as a reference (&) but reconfigure() expects an owned value. Please dereference the borrowed reference by changing to aptos_governance::reconfigure(*framework_signer).
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
sherry-x
force-pushed
the
update-governance-threshold
branch
from
3615784 to
167e3ee
Compare
Comment on lines
+5
to
+6
| let framework_signer = aptos_governance::get_signer_testnet_only(account, | ||
| @0000000000000000000000000000000000000000000000000000000000000001); |
There was a problem hiding this comment.
This code uses get_signer_testnet_only() which is restricted to testnet environments. For mainnet deployment, please use get_signer() instead. The testnet-only version will cause the transaction to fail on mainnet.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist