Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extended PM with permission owner and delegation capabilities #604

Open
wants to merge 85 commits into
base: develop
Choose a base branch
from
Open

feat: Extended PM with permission owner and delegation capabilities #604

wants to merge 85 commits into from

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Aug 28, 2024 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-?

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

novaknole
novaknole reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@novaknole novaknole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st Round ^_^

clauBv23
clauBv23 reviewed Sep 16, 2024
View reviewed changes
packages/contracts/src/core/permission/PermissionManager.sol
if (_isPermissionFrozen(permission)) {
revert PermissionFrozen(_where, _permissionIdOrSelector);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this check is being done in several places, I would consider moving it to a modifier

novaknole and others added 21 commits September 16, 2024 17:30
@novaknole
add tests and fixes to dao (#608)
afe70be
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
e688034 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
d0a83db 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
46c191a 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
cead54b 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
154eb40 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
6abaebf 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
c6479de 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
cc44e88 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
0b10859 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
0ceabf1 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
ab63589 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
dccda8a 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
d3a9978 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
10fd26b 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
ae3fa2d 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
bd934f4 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole @clauBv23
Update packages/contracts/src/core/permission/PermissionManager.sol
352f8a2 
Co-authored-by: Claudia Barcelo <[email protected]>
@novaknole
fix typo
921c2fb
@novaknole
ownerAuth as internal virtual function
aaa72fc
@novaknole
add natspec for struct permission:
8c658ea
@novaknole
fix more tests and cleaner (#609)
4ec5af9 
* fix more tests and cleaner

* test fixes + permissionFrozen for multi target + more fixes

* improve natspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauBv23 clauBv23 clauBv23 left review comments

@novaknole novaknole Awaiting requested review from novaknole

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nivida @novaknole @clauBv23