Use timeout duration of connection attempt according to connection type #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 7 7
Lines 691 691
Branches 83 83
=======================================
Hits 623 623
Misses 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 7df59d7
Click for full report table
Click for full report CSV |
fabik111
changed the title
pennam
approved these changes
Jul 17, 2025
| switch (_networkSetting.type) { | ||
| #if defined(BOARD_HAS_WIFI) | ||
| case NetworkAdapter::WIFI: | ||
| timeout = 15000; // 15 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 15000; // 15 seconds | |
| timeout = NC_CONNECTION_TIMEOUT_ms; // 15 seconds |
|
|
||
| #if defined(BOARD_HAS_ETHERNET) | ||
| case NetworkAdapter::ETHERNET: | ||
| timeout = 15000; // 15 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 15000; // 15 seconds | |
| timeout = NC_CONNECTION_TIMEOUT_ms; // 15 seconds |
|
|
||
| #if defined(BOARD_HAS_LORA) | ||
| case NetworkAdapter::LORA: | ||
| timeout 15000; // 15 seconds |
There was a problem hiding this comment.
Suggested change
| timeout 15000; // 15 seconds | |
| timeout NC_CONNECTION_TIMEOUT_ms; // 15 seconds |
| break; | ||
| #endif | ||
| default: | ||
| timeout = 15000; // Default to 15 seconds for other adapters |
There was a problem hiding this comment.
Suggested change
| timeout = 15000; // Default to 15 seconds for other adapters | |
| timeout = NC_CONNECTION_TIMEOUT_ms; // Default to 15 seconds for other adapters |
|
|
||
| #if defined(BOARD_HAS_CELLULAR) | ||
| case NetworkAdapter::CELL: | ||
| timeout = 30000; // 30 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 30000; // 30 seconds | |
| timeout = 2 * NC_CONNECTION_TIMEOUT_ms; // 30 seconds |
|
|
||
| #if defined(BOARD_HAS_CATM1_NBIOT) | ||
| case NetworkAdapter::CATM1: | ||
| timeout = 30000; // 30 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 30000; // 30 seconds | |
| timeout = 2 * NC_CONNECTION_TIMEOUT_ms; // 30 seconds |
|
|
||
| #if defined(BOARD_HAS_GSM) | ||
| case NetworkAdapter::GSM: | ||
| timeout = 30000; // 30 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 30000; // 30 seconds | |
| timeout = 2 * NC_CONNECTION_TIMEOUT_ms; // 30 seconds |
|
|
||
| #if defined(BOARD_HAS_NB) | ||
| case NetworkAdapter::NB: | ||
| timeout = 30000; // 30 seconds |
There was a problem hiding this comment.
Suggested change
| timeout = 30000; // 30 seconds | |
| timeout = 2 * NC_CONNECTION_TIMEOUT_ms; // 30 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the timeout duration of a connection attempt according to the configured connectivity type