Added an example#42
Open
jeeva2812 wants to merge 4 commits intoarduino-libraries:masterfrom
jeeva2812:master
Open
Added an example#42jeeva2812 wants to merge 4 commits intoarduino-libraries:masterfrom jeeva2812:master
jeeva2812 wants to merge 4 commits intoarduino-libraries:masterfrom
jeeva2812:master
Conversation
per1234
previously requested changes
Mar 19, 2020
Author
|
Will do all the required changes |
Author
|
PR updated |
|
|
Author
|
Can you please approve this PR @per1234 |
Contributor
|
Hi @jeeva2812. I commented last year that the changes I requested during my review has been resolved:
It is not my role in this project to decide which examples are accepted into the library though. |
per1234
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example to portray the use of
readfunction