Skip to content

Show maintainer instead of author in lib manager #10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021
Merged

Show maintainer instead of author in lib manager #10849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
installButtonPlaceholder.setVisible(!(installable || upgradable));

String name = selected.getName();
String author = selected.getAuthor();
// String maintainer = selectedLib.getMaintainer();
// String author = selected.getAuthor();
String maintainer = selected.getMaintainer();
final String website = selected.getWebsite();
String sentence = selected.getSentence();
String paragraph = selected.getParagraph();
Expand All @@ -168,8 +168,8 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,

// ...author...
desc += format("<font color=\"{0}\">", midcolor);
if (author != null && !author.isEmpty()) {
desc += format(" by <b>{0}</b>", author);
if (maintainer != null && !maintainer.isEmpty()) {
desc += format(" by <b>{0}</b>", maintainer);
}

// ...version.
Expand All @@ -196,7 +196,7 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
desc += format("{0}", paragraph);
desc += "<br />";
}
if (author != null && !author.isEmpty()) {
if (maintainer != null && !maintainer.isEmpty()) {
desc = setButtonOrLink(moreInfoButton, desc, moreInfoLbl, website);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this change, but why does this if exist? Seems like you don't get a "More info" button/link when no author (or now maintainer) is set, but that doesn't make sense to me?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should be website != null && !website.isEmpty(), I guess we may fix it together with this PR.


Expand Down