Skip to content

Reduce storage consumption of ping command for C33 #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Reduce storage consumption of ping command for C33 #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libraries/lwIpWrapper/src/CNetIf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "CNetIf.h"
#include <functional>
#include <stdlib.h>
#include "lwip/include/lwip/raw.h"
#include "lwip/include/lwip/icmp.h"
#include "lwip/include/lwip/ip_addr.h"
Expand All @@ -23,7 +24,9 @@ static u8_t icmp_receive_callback(void *arg, struct raw_pcb *pcb, struct pbuf *p
struct icmp_echo_hdr *iecho;
(void)(pcb);
(void)(addr);
LWIP_ASSERT("p != NULL", p != NULL);
if(p == NULL) {
return 0; /* don't consume the packet */
}

recv_callback_data* request = (recv_callback_data*)arg;
if ((p->tot_len < (PBUF_IP_HLEN + sizeof(struct icmp_echo_hdr))) ||
Expand Down Expand Up @@ -164,7 +167,8 @@ int CLwipIf::ping(IPAddress ip, uint8_t ttl)

/* initialize callback data for a new request */
memset(&requestCbkData, 0, sizeof(recv_callback_data));
requestCbkData.seqNum = (uint16_t)random(0xffff);
srand(millis());
requestCbkData.seqNum = (uint16_t)rand()%65535;

/* Create a raw socket */
struct raw_pcb* s = raw_new(IP_PROTO_ICMP);
Expand Down
Loading