Skip to content

Use golangci-lint instead of golint#778

Open
per1234 wants to merge 1 commit intoarduino:mainfrom
per1234:golangci-lint
Open

Use golangci-lint instead of golint#778
per1234 wants to merge 1 commit intoarduino:mainfrom
per1234:golangci-lint

Conversation

@per1234
Copy link
Copy Markdown
Contributor

@per1234 per1234 commented Oct 15, 2024

golint has been deprecated.

golint has been deprecated.
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Oct 15, 2024
@per1234 per1234 self-assigned this Oct 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (b9f5a82) to head (6bf30f3).
⚠️ Report is 619 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #778   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files          44       44           
  Lines        6800     6800           
=======================================
  Hits         6124     6124           
  Misses        553      553           
  Partials      123      123           
Flag Coverage Δ
unit 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor Author

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codebase produces many linting errors from golangci-lint, even though it was passing golint. I think this should be put on hold until #761 is merged as the fixes for the linting errors might cause merge conflicts with the work done in that PR.

@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Oct 16, 2024
@per1234 per1234 added status: changes requested Changes to PR are required before merge and removed status: blocked Progress on this prevented by an external cause labels Nov 25, 2024
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 18, 2026

CLA assistant check
All committers have signed the CLA.

@arduino arduino deleted a comment from CLAassistant Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes requested Changes to PR are required before merge topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants