feat: start arduino-router-serial only if serial available#51
Open
lucarin91 wants to merge 5 commits intoarduino:mainfrom
Open
feat: start arduino-router-serial only if serial available#51lucarin91 wants to merge 5 commits intoarduino:mainfrom
arduino-router-serial only if serial available#51lucarin91 wants to merge 5 commits intoarduino:mainfrom
Conversation
lucarin91
changed the title
arduino-router-serial only if serial available
Member
|
LGTM as a first fix, but it would be awesome to start/restart the service when ttyGS0 appears/disappears (eg. if the boards is powered by VIN and the user connects the PC on the fly) |
facchinm
approved these changes
Apr 27, 2026
Contributor
Author
That is already working like that, the .path triggers the unit restart when ttyGSO appears |
| After=network.target arduino-router.service | ||
| Wants=network.target arduino-router.service | ||
| Requires=arduino-router.service | ||
| ConditionPathExists=/dev/ttyGS0 |
Contributor
There was a problem hiding this comment.
This can be removed, the service will start because of the path Unit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need the serial forward to ide2 only if the linux serial is up. If the board is in SBC mode, it will not be available.
Change description
Use the path trigger for starting socat only in usb mode.
Additional Notes
Reviewer checklist
main.