Fixed Tab key behaviour during code completion. #194
Merged
+27,544
−26,233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ubi de feo <[email protected]>
Signed-off-by: ubi de feo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to change the behaviour of the Tab key, this PR rebuilds CodeMirror with different parameters.
The diff is huge because it's entirely built into a static file, so it is advised to just look at
static_libs/codemirror.js, which is the source for generatingui/arduino/libs/codemirror.js.Both
build_choo.jsandbuild_codemirror.jshave been moved from their original location because they are used to build the final artefacts (not yet automated inpackage.json).A new build script is added which will generate static versions of both into the
ui/arduino/libsfolder.