Add DI support for twill Block getData method #2292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have been trying to use Twill Block, and extend it like it's documented in https://twillcms.com/docs/block-editor/rendering-blocks.html#content-modifying-block-data, though no method supports DI. This change would allow to use DI in getData() method.
Regarding the changes Laravel itself likes to do things like that, ex. https://github.com/laravel/framework/blob/10.x/src/Illuminate/Mail/Mailable.php#L1612-L1614
Also had a discussion on Discord to create this PR