Skip to content

feat: redirect to login for unauthenticated users in application settings and user info #16676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
robinlieb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: redirect to login for unauthenticated users in application settings and user info #16676

robinlieb wants to merge 1 commit into from
+6 −3

Conversation

@robinlieb
Copy link
Member

@robinlieb robinlieb commented Dec 21, 2023

Closes #16675

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@robinlieb robinlieb requested a review from a team as a code owner December 21, 2023 15:49
@codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.75%. Comparing base (234c7ec) to head (acf8b0e).

Files Patch % Lines
server/session/session.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16676      +/-   ##
==========================================
- Coverage   52.75%   52.75%   -0.01%     
==========================================
  Files         316      316              
  Lines       43540    43542       +2     
==========================================
  Hits        22970    22970              
- Misses      18023    18024       +1     
- Partials     2547     2548       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinlieb robinlieb force-pushed the feat/login-redirect branch from 625b8e6 to acf8b0e Compare July 30, 2024 20:02
@robinlieb robinlieb force-pushed the feat/login-redirect branch from acf8b0e to d0db30a Compare December 7, 2025 07:44
@robinlieb robinlieb force-pushed the feat/login-redirect branch from d0db30a to 894b12d Compare February 2, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redirect to Login for Unauthenticated Users in Application Settings/User Info

1 participant

@robinlieb