-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat: show application-added repositories in the repo list #24094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show application-added repositories in the repo list #24094
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
|
Hi, @Lukas-solar @crenshaw-dev I’ve proposed an improvement for this issue. Could you please review it? |
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for working on this PR. I tested your changes locally and have few questions to ask based on this comment.
-
I've an application connected to a repository but the app counts is showing as 0. I think this is happening because the repo url field in application doesn't contian
.gitwhile the repo link while trying to add the repo doesn't contain.git. Can we fix this?

-
repo summary links to the filtered app list
Where can i see this?
Hi, thank you for pointing this out. I hadn’t accounted for the presence of .git in the repo URLs.
Regarding point 2,
it means that in the repo detail view you can check the links for connected apps, and clicking on one of those links will take you to the corresponding application summary page. The flow looks like this: |
|
Thanks for the PR. It looks very good and clear to me! |
|
I really like the list of all repositories. May I ask what the difference is between “connected-repo-app” and “disconnected” on the backend side? I am particularly interested in repos that have no access restrictions like public repos. |
Hi Lukas, thanks for the positive feedback on the PR! there were no backend changes included in this proposal. If so, those are custom UI-only states added to distinguish between repositories that were explicitly created and registered via the settings/repos page (i.e., "connected"), and repositories that were created from an application but not yet listed in the registered repo list (i.e., "disconnected"). Let me know if you were referring to something else! |
|
I think I understand that part. I was just wondering why we don't also register the repositories that were created from an application directly (ui="disconnected"), i.e., change the backend code. So, a kind of auto-connect without credentials, if none are necessary. But to understand why this separation exists, I asked about the differences in the states in the backend. |
Ah, I see. I also considered adding repositories that were created directly from the application as disconnected in the repos data, but in that case, the dataset that makes up the repos would need to be changed. In particular, it would be difficult to decide what type of repo (http/https or ssh) is being created and what the appropriate data should be. I also wonder whether it’s even necessary to add unauthenticated repos to the database in the first place. |
|
@nitishfy |
484ede7 to
7208578
Compare













Closes #23720
Checklist: