test: use unique app name per test #25720
Merged
+56
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25720 +/- ##
==========================================
- Coverage 62.59% 62.58% -0.01%
==========================================
Files 353 353
Lines 50120 50120
==========================================
- Hits 31374 31370 -4
- Misses 15729 15731 +2
- Partials 3017 3019 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexandre Gaudreault <[email protected]>
agaudreault
force-pushed
the
test-unique-name
branch
from
debed9c to
65d131e
Compare
blakepettersson
approved these changes
Dec 17, 2025
kingbj940429
pushed a commit
to kingbj940429/argo-cd
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Alexandre Gaudreault <[email protected]>
14 tasks
reggie-k
added
the
cherry-pick/3.3
|
❌ Cherry-pick failed for 3.3. Please check the workflow logs for details. |
argo-cd-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Alexandre Gaudreault <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem is with the resource tracking. When tests are run by a retry, or executed locally, it is possible that resources already exist in terminating state (done at the start of tests during the EnsureCleanState) and the tests will pick these up.
This change will increase stability, and is a small step towards parallelism.
Related to #24307
As a result, current e2e are updated if they were hardcoding the ApplicationName