docs: Remove references to no longer used tls-server-name flag

[kwentine]

The --tls-server-name flag is documented, but no longer used.

Remove all remaining references:

$ find docs/ -name '*.md' -execdir sed -i /--tls-server-name/d {} +
$ git grep tls-server-name || echo No matches
No matches

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[kwentine]

I apologize for being a bit candid, I should have suspected that these snippets were generated. However, I cannot understand whence the --tls-server-name comes 🤔

[choejwoo]

As you suspected, those flags are generated. --tls-server-name comes from Kubernetes client-go (clientcmd)’s recommended kubeconfig override flags (not Argo CD itself), which is why it shows up in the generated command docs.

Here are a few references.

• https://github.com/kubernetes/client-go/blob/master/tools/clientcmd/overrides.go#L146-L167
• https://github.com/argoproj/notifications-engine/blob/8c0c96d8d530d9bac76aa24d914d4d22294ac8b1/pkg/cmd/tools.go
• https://github.com/argoproj/argo-cd/blob/master/cmd/argocd/commands/admin/notifications.go

By the way, I’m not super familiar with the CLI plumbing here, but since this flag is a persistent/inherited kubeconfig override flag, how did you determine that it’s no longer used?

[kwentine]

Thanks a lot for providing these references, from which I started to derive some basic understanding of the apparatus.

since this flag is a persistent/inherited kubeconfig override flag, how did you determine that it’s no longer used?

I tried to use it in the process of troubleshooting an inadequate SAN on a TLS certificate:

$ argocd app --tls-server-name=example.com list -o name
Error: unknown flag: --tls-server-name

Which got me intrigued so I went and git grep tls-server-name and found only documentation matches. "Surely that must be outdated" I concluded. And here I am on the verge of learning about CLI plumbing in Go 😄

So what's the next step to fix this? I noticed that argocd admin template does honor the flag, so I presume it amounts to understanding what the notification engine CLI does differently...

$ argocd admin notifications --tls-server-name=example.com template get 
failed to get api: Get "https://<URL>": tls: failed to verify certificate: x509: certificate is valid for ingress.local, not example.com

[choejwoo]

Thanks for the detailed analysis.
It looks like the Argo CD repo itself mainly consumes changes from the related/vendor components.
If the intent is to change the behavior of this flag, it probably needs to be investigated across the connected repositories (e.g. the notification engine CLI), rather than only within this repo.

[nitishfy]

Interesting. @choejwoo you're correct, these flags are coming fron client-go and not Argo CD. I think this might be happening based on here. I'll have to dig deeper to understand why it is happening. Meanwhile, i'll create an issue and bring this up in meeting.

[nitishfy]

#25875

[kwentine]

@nitishfy keep me posted I'd be happy to work on a fix (if one is deemed necessary) with some guidance.

[todaywasawesome]

Closing in favor of issue #25875 which should be a new PR