Skip to content

feat: add --no-install-recommends in argocd-base #25841 #25852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crenshaw-dev merged 2 commits into from
Jan 6, 2026
Merged

feat: add --no-install-recommends in argocd-base #25841 #25852

crenshaw-dev merged 2 commits into from
Jan 6, 2026

Conversation

@zeraye
Copy link
Contributor

@zeraye zeraye commented Jan 5, 2026 •
edited
Loading

I added --no-install-recommends in argocd-base and removed /usr/share/doc to reduce docker image size by 9193785 bytes (8.77 Mebibytes).

I had to add openssh-client as an explicit dependency because it is a required dependency that was previously pulled in implicitly via recommended packages. This is explained in the issue linked below.

Closes #25841

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@zeraye
feat: add --no-install-recommends in argocd-base
4ed16be 
Signed-off-by: Jakub Rudnik <jakub@rudnik.io>
@zeraye zeraye requested a review from a team as a code owner January 5, 2026 08:10
@bunnyshell
Copy link

bunnyshell bot commented Jan 5, 2026 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@zeraye zeraye mentioned this pull request Jan 5, 2026
Closed
ppapapetrou76
ppapapetrou76 approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@ppapapetrou76 ppapapetrou76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@crenshaw-dev crenshaw-dev merged commit 73b4d98 into argoproj:master Jan 6, 2026
26 checks passed
vishwagandhi1610 pushed a commit to vishwagandhi1610/argo-cd that referenced this pull request Jan 7, 2026
@zeraye @nitishfy @vishwagandhi1610
feat: add --no-install-recommends in argocd-base argoproj#25841 (a…
e0bda6f 
…rgoproj#25852)

Signed-off-by: Jakub Rudnik <jakub@rudnik.io>
Co-authored-by: Nitish Kumar <justnitish06@gmail.com>
Signed-off-by: Vishwa Gandhi <vishwagandhi1610@gmail.com>
@dudinea dudinea mentioned this pull request Jan 12, 2026
Closed
3 tasks
@saernz saernz mentioned this pull request Jan 14, 2026
Closed
@dudinea dudinea mentioned this pull request Jan 15, 2026
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

+1 more reviewer

@ppapapetrou76 ppapapetrou76 ppapapetrou76 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add --no-install-recommends in argocd-base

4 participants

@zeraye @crenshaw-dev @ppapapetrou76 @nitishfy