Skip to content

Conversation

@bbaja42
Copy link
Contributor

@bbaja42 bbaja42 commented Jan 6, 2026

previously, the complete example was under #Deletion Strategies

while actually, the example is a full example, for both creation and deletion

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@bbaja42 bbaja42 requested review from a team as code owners January 6, 2026 16:49
@bunnyshell
Copy link

bunnyshell bot commented Jan 6, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bbaja42 bbaja42 changed the title Change heading for the complete example for argocd progressive rollout docs: Change heading for the complete example for argocd progressive rollout Jan 6, 2026
Copy link
Contributor

@pjiang-dev pjiang-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please sign off your commit

@bbaja42
Copy link
Contributor Author

bbaja42 commented Jan 6, 2026

Hmm, I'm a bit confused. I do see its signed? But I also see errors?
Screenshot 2026-01-06 at 20 30 59

https://github.com/argoproj/argo-cd/pull/25878/checks?check_run_id=59595854230

Commit sha: [f1f61c9](https://github.com/argoproj/argo-cd/pull/25878/commits/f1f61c9a12a7e117ef1e86212bb8bf5c94009a54), Author: Barisa Obradovic, Committer: GitHub; Expected "Barisa Obradovic [[email protected]](mailto:[email protected])", but got "Barisa Obradovic [[email protected]](mailto:[email protected])".

Expected and got look the same to me?

bbaja42 and others added 2 commits January 6, 2026 20:47
previously, the complete example was under #Deletion Strategies

while actually, the example is a full example, for both creation and deletion

Signed-off-by: Barisa Obradovic  <[email protected]>
Signed-off-by: Barisa Obradovic <[email protected]>
…r` and `argocd-notifications-controller` (argoproj#25872)

Signed-off-by: Alex Recuenco <[email protected]>
Signed-off-by: Barisa Obradovic <[email protected]>
@bbaja42
Copy link
Contributor Author

bbaja42 commented Jan 6, 2026

Tried again after doing DCO steps correctly, sorry for the noise.

@todaywasawesome todaywasawesome enabled auto-merge (squash) January 8, 2026 15:46
@todaywasawesome todaywasawesome merged commit abde222 into argoproj:master Jan 8, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants