fix(ui): Parameters tab should correctly show dry source parameters #26179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
Signed-off-by: Jonathan Winters <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
agaudreault
requested changes
Jan 30, 2026
| func (spec *ApplicationSpec) GetSources() ApplicationSources { | ||
| if spec.SourceHydrator != nil { | ||
| return ApplicationSources{spec.SourceHydrator.GetSyncSource()} | ||
| return ApplicationSources{spec.SourceHydrator.GetDrySource(), spec.SourceHydrator.GetSyncSource()} |
Member
There was a problem hiding this comment.
This drastically change the behaviour of the function. Usually, having multiple sources returned means it is a multi-source apps. In this case, we have a single source app, and a dry-source that only applies to the hydrator. Changing this function means you should validate the behaviour of every caller, and I think it is called a lot in the codebase.
Perhaps creating a new function to return all the source for the hydrator would have a smaller blast radius.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup for #26152.
GetSourcesto also allow the dry sourcegetAppDetailsfrom the frontendnote: this PR is built on top of #26152, so that PR's changes are also in here.
Checklist: