fix: downgrade DiffFromCache log level for cache-miss errors #26185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR downgrades the log level for DiffFromCache errors caused by expected Redis cache misses (specifically cache: key is missing) from ERROR to WARN, while preserving ERROR logs for genuine Redis failures.
The diff behaviour and control flow are unchanged; Argo CD continues to fall back to a non-cache diff when the cache is unavailable.
Motivation
In Redis HA / Sentinel setups, cache misses are expected during events such as:
In these scenarios, Argo CD currently logs
DiffFromCachefailures atERRORlevel even though:This results in repeated error-level log noise and false alerts in otherwise healthy clusters.
What this PR changes
Why this is safe
Scope
Related issues
Fixes: #5068