-
Notifications
You must be signed in to change notification settings - Fork 6.8k
server: bypass auth for gRPC health checks #26199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Piyushkhobragade
wants to merge
82
commits into
argoproj:master
from
Piyushkhobragade:fix-grpc-health-auth-bypass
Closed
server: bypass auth for gRPC health checks #26199
Piyushkhobragade
wants to merge
82
commits into
argoproj:master
from
Piyushkhobragade:fix-grpc-health-auth-bypass
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
….2) (argoproj#24582) Signed-off-by: Patroklos Papapetrou <[email protected]> Co-authored-by: Papapetrou Patroklos <[email protected]>
…roj#24601 for 3.2) (argoproj#24604) Signed-off-by: José Maia <[email protected]> Co-authored-by: José Maia <[email protected]>
…ick argoproj#24622 for 3.2) (argoproj#24623) Signed-off-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]>
…r 3.2) (argoproj#24648) Signed-off-by: Blake Pettersson <[email protected]> Co-authored-by: Blake Pettersson <[email protected]>
…argoproj#24641) Signed-off-by: Atif Ali <[email protected]> Co-authored-by: Atif Ali <[email protected]>
…j#24632) (argoproj#24653) Signed-off-by: Koray Oksay <[email protected]> Co-authored-by: Koray Oksay <[email protected]>
argoproj#24525 for 3.2) (argoproj#24686) Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
…(cherry-pick argoproj#24664 for 3.2) (argoproj#24680) Signed-off-by: puretension <[email protected]> Co-authored-by: DOHYEONG LEE <[email protected]>
…oproj#24697) Signed-off-by: Alexander Matyushentsev <[email protected]>
…olicy (cherry-pick argoproj#24707 for 3.2) (argoproj#24713) Signed-off-by: AvivGuiser <[email protected]> Co-authored-by: AvivGuiser <[email protected]>
…ult (argoproj#24698) (argoproj#24711) Signed-off-by: Alexander Matyushentsev <[email protected]>
…isabled (cherry-pick argoproj#24587 for 3.2 (argoproj#24716) Signed-off-by: Atif Ali <[email protected]>
…oj#24726 for 3.2) (argoproj#24760) Co-authored-by: Leonardo Luz Almeida <[email protected]>
…rry-pick argoproj#24782 for 3.2) (argoproj#24784) Signed-off-by: Jonasz Łasut-Balcerzak <[email protected]> Co-authored-by: Jonasz Łasut-Balcerzak <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Fixed a race condition in repository credentials handling by implementing deep copying of secrets before modification. This prevents concurrent map read/write panics when multiple goroutines access the same secret. The fix ensures thread-safe operations by always operating on copies rather than shared objects. Signed-off-by: Ville Vesilehto <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
…roj#24809) Signed-off-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…rry-pick argoproj#24822 for 3.2) (argoproj#24827) Signed-off-by: gyu-young-park <[email protected]> Co-authored-by: gyu-young-park <[email protected]>
…proj#24826 for 3.2) (argoproj#24828) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…goproj#24842) Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
… retrieval (argoproj#24832) (cherry-pick argoproj#24851 for 3.2) (argoproj#24865) Signed-off-by: Viacheslav Rianov <[email protected]> Co-authored-by: Rianov Viacheslav <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
…3.2) (argoproj#24891) Signed-off-by: Carlos Rodriguez-Fernandez <[email protected]>
…rgoproj#24862 for 3.2) (argoproj#24912) Signed-off-by: Jakub Ciolek <[email protected]> Co-authored-by: Jakub Ciolek <[email protected]>
…son (cherry-pick argoproj#24971 for 3.2) (argoproj#24973) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…oproj#23586 for 3.2) (argoproj#25415) Signed-off-by: Nathanael Liechti <[email protected]> Co-authored-by: Nathanael Liechti <[email protected]>
…rgoproj#25650 for 3.2) (argoproj#25718) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: reggie-k <[email protected]>
…#25791) Signed-off-by: anandf <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: reggie-k <[email protected]>
…-pick argoproj#25706 for 3.2) (argoproj#25795) Signed-off-by: reggie-k <[email protected]> Co-authored-by: Regina Voloshin <[email protected]>
Signed-off-by: nitishfy <[email protected]> Co-authored-by: Papapetrou Patroklos <[email protected]>
…rgoproj#25814) Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>
…oproj#25859) Signed-off-by: reggie-k <[email protected]> Co-authored-by: Regina Voloshin <[email protected]>
Signed-off-by: nitishfy <[email protected]>
…… (cherry-pick argoproj#25066 for 3.2) (argoproj#25895) Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]>
…owed namespaces when updating a cluster secret (cherry-pick argoproj#25622 for 3.2) (argoproj#25911) Signed-off-by: OpenGuidou <[email protected]> Co-authored-by: OpenGuidou <[email protected]>
…1223091026 8c0c96d8d530 (argoproj#25930) Signed-off-by: reggie-k <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: reggie-k <[email protected]>
Signed-off-by: reggie-k <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: reggie-k <[email protected]>
…herry-pick argoproj#25824 for 3.2) (argoproj#26006) Signed-off-by: chentiewen <[email protected]> Co-authored-by: QingHe <[email protected]> Co-authored-by: chentiewen <[email protected]> Co-authored-by: Claude Sonnet 4.5 <[email protected]>
…5870) (cherry-pick argoproj#26011 for 3.2) (argoproj#26012) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…rry-pick argoproj#26014 for 3.2) (argoproj#26016) Signed-off-by: Michael Crenshaw <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]>
…cherry pick argoproj#26039 for 3.2) (argoproj#26070) Signed-off-by: Eugene Doudine <[email protected]>
…l panic (cherry-pick argoproj#26065 for 3.2) (argoproj#26074) Signed-off-by: John Soutar <[email protected]>
Signed-off-by: Codey Jenkins <[email protected]> Signed-off-by: pbhatnagar-oss <[email protected]> Co-authored-by: pbhatnagar-oss <[email protected]> Co-authored-by: Alexandre Gaudreault <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: crenshaw-dev <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gRPC health checks returning Unauthenticated when auth is enabled.
Health RPCs are exempted at the interceptor layer while preserving
existing authentication behavior for all other RPCs.
Fixes #26193