chore(deps): migrated aws sdk v1 to v2 for EKS with argocd-k8s-auth #26200
Conversation
Signed-off-by: reggie-k <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: reggie-k <[email protected]>
| if profile != "" { | ||
| opts = append(opts, config.WithSharedConfigProfile(profile)) | ||
| } | ||
| cfg, err := config.LoadDefaultConfig(ctx, opts...) |
There was a problem hiding this comment.
| if roleARN != "" { | ||
| creds := stscreds.NewCredentials(sess, roleARN) | ||
| stsAPI = sts.New(sess, &aws.Config{Credentials: creds}) | ||
| appCreds := stscreds.NewAssumeRoleProvider(client, roleARN) |
There was a problem hiding this comment.
According to AWS Security Token Service Credentials in https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/migrate-gosdk.html
| request.HTTPRequest.Header.Add(clusterIDHeader, clusterName) | ||
| signed, err := request.Presign(requestPresignParam) | ||
|
|
||
| presignClient := sts.NewPresignClient(client) |
There was a problem hiding this comment.
According to Presigned Requests in the migration guide.
Another way to implement this was using middleware, according to HTTP request/response in the guide, but this way an invalid token was generated.
agaudreault
left a comment
agaudreault
left a comment
There was a problem hiding this comment.
LGTM, but I haven't tested it with eks cluster
ppapapetrou76
left a comment
ppapapetrou76
left a comment
There was a problem hiding this comment.
LGTM I left a few optional code improvements
| if roleARN != "" { | ||
| creds := stscreds.NewCredentials(sess, roleARN) | ||
| stsAPI = sts.New(sess, &aws.Config{Credentials: creds}) | ||
| appCreds := stscreds.NewAssumeRoleProvider(client, roleARN) | ||
| cfg.Credentials = aws.NewCredentialsCache(appCreds) | ||
| client = sts.NewFromConfig(cfg) |
There was a problem hiding this comment.
I know that this is not added entirely in this PR but it would be nice if we can add UT - optional ofc
Co-authored-by: Papapetrou Patroklos <[email protected]> Signed-off-by: Regina Voloshin <[email protected]>
Co-authored-by: Papapetrou Patroklos <[email protected]> Signed-off-by: Regina Voloshin <[email protected]>
3 participants
Related to #12419
Previous PR:
#25222
cmd/argocd-k8s-auth/commands/aws.gokubectlusing anargocd-k8s-authgenerated-token against a live EKS cluster - with IAM role, AWS_PROFILE and AWS cred env vars.Checklist: