fix: filter git describe to version tags only #26221
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
argocd admin dashboardfailed withfailed to get versionon v3.3.0 #26220" or "Fixesargocd admin dashboardfailed withfailed to get versionon v3.3.0 #26220" in the description to auto-close the related issue.Changes
The
stabletag tracks the latest GA release, so it can share a commit with a version tag (e.g.v3.3.0). When both are lightweight tags on the same commit,git describe --exact-match --tags HEADreturnsstable(alphabetically first), which gets injected asgitTagvia ldflags. The ArgoCD server then rejects the client:This adds
--match 'v*'to thegit describeinvocation so it only considers version-prefixed tags.Test plan
There is no Makefile test framework in this project. This is a one-line change to a
git describeinvocation, so here is a CLI reproduction and fix demonstration using the actual ArgoCD repo at v3.3.0 where bothstableandv3.3.0are lightweight tags on the same commit:Closes #26220