fix(controller): handle nil processedTmpl in DAGs#13548
Merged
Conversation
chengjoey
force-pushed
the
fix/controller-panic
branch
from
September 2, 2024 09:05
eb9db41 to
daae9f2
Compare
Joibel
reviewed
Sep 2, 2024
Signed-off-by: joey <zchengjoey@gmail.com>
chengjoey
force-pushed
the
fix/controller-panic
branch
from
September 2, 2024 09:41
daae9f2 to
d7da631
Compare
chengjoey
commented
Sep 2, 2024
Joibel
requested changes
Sep 2, 2024
Joibel
left a comment
Joibel
left a comment
Member
There was a problem hiding this comment.
As you have a reproducible test case, could you add it as a regression test please?
Member
Author
terrytangyuan
approved these changes
Sep 11, 2024
terrytangyuan
left a comment
terrytangyuan
left a comment
Member
There was a problem hiding this comment.
I think this is a great fix for edge cases even though it cannot be reproduced easily. WDYT? @Joibel
Joibel
approved these changes
Sep 18, 2024
Member
|
@chengjoey Thanks for this |
Joibel
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Sep 19, 2024
Signed-off-by: joey <zchengjoey@gmail.com>
Joibel
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: joey <zchengjoey@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13547
Motivation
It seems more reasonable to judge
processedTmpl != nil