Rebase of #503 #771
Open
Rebase of #503 #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2025 12:43
Signed-off-by: Matt Pryor <[email protected]>
Signed-off-by: Matt Pryor <[email protected]>
|
This was referenced Sep 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #771 +/- ##
==========================================
- Coverage 54.26% 46.97% -7.30%
==========================================
Files 64 64
Lines 6164 6557 +393
==========================================
- Hits 3345 3080 -265
- Misses 2549 3220 +671
+ Partials 270 257 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dprotaso
commented
Sep 3, 2025
| @@ -50,6 +50,8 @@ const ( | |||
| SyncOptionClientSideApplyMigration = "ClientSideApplyMigration=true" | |||
| // Sync option that disables client-side apply migration | |||
| SyncOptionDisableClientSideApplyMigration = "ClientSideApplyMigration=false" | |||
| // Sync option that means only controller owner references are respected | |||
| SyncOptionControllerReferencesOnly = "ControllerReferencesOnly=true" | |||
There was a problem hiding this comment.
I'm curious how this options can become the default. Is there a concept in the Argo project as feature gates.
eg. where it's opt-in and then the flag get's switched to opt out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #503
Fixes: #501