chore: bump k8s v1.34 #773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jiang <[email protected]>
Signed-off-by: Peter Jiang <[email protected]>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 54.26% 47.30% -6.97%
==========================================
Files 64 64
Lines 6164 6577 +413
==========================================
- Hits 3345 3111 -234
- Misses 2549 3209 +660
+ Partials 270 257 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
overall looks good to me. can you create a PR argo cd referencing this change so we can see the e2e tests? |
rumstead
approved these changes
Sep 5, 2025
|
argoproj/argo-cd#24405 passing e2e tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixies argoproj/argo-cd#24372
Changes
runtime.DefaultUnstructuredConverter.FromUnstructured(obj.Object, &wf)no longer works with 1.34, refactored to remove this in favor of direct field access.