-
Notifications
You must be signed in to change notification settings - Fork 297
Track ownerrefs between cluster-scoped and namespaced objects #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Track ownerrefs between cluster-scoped and namespaced objects #774
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #774 +/- ##
==========================================
- Coverage 54.26% 47.82% -6.45%
==========================================
Files 64 64
Lines 6164 6622 +458
==========================================
- Hits 3345 3167 -178
- Misses 2549 3199 +650
+ Partials 270 256 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jonathan Ogilvie <[email protected]>
68c589d
to
d042f32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, as was suggested in contrib meeting we should have an environmental variable. I think this should be disabled by default and only enabled when needed.
I heard some other opinions in the contributor meeting. I agree with adding the escape hatch, but I'm not sure whether we should implement "conditional enable" or "emergency disable". Environment variable? App annotation? Other thoughts? @crenshaw-dev had an opinion I know. |
…up comments Signed-off-by: Jonathan Ogilvie <[email protected]>
|
I went ahead with implementing this as a disable flag. I did have an idea about a possible optimization, though it may change things a little more broadly than just I was thinking if |
Fixes argoproj/argo-cd#24379