fix: make parameter name fallback null-safe in Predicate::formatSummaryCall #16179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Formatting function calls in counterexamples could dereference a null parameter pointer when a parameter is absent and no concrete value is available, leading to undefined behavior.
Change: Guard against null params.at(i) and use a safe fallback: prefer the parameter’s actual name when available, otherwise use the placeholder param_. The existing “counterexample incomplete” note remains unchanged.
Goal: Eliminate potential UB and make counterexample formatting robust. This aligns with existing null checks in nearby code (e.g., CHC.cpp, RenameSymbol.cpp) and follows existing placeholder naming (param_) used elsewhere. Tests pass.