Skip to content

Clean Up Redundant Utilities and Fix Gas Report Parsing #16283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Doryu001 wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −4
Open

Clean Up Redundant Utilities and Fix Gas Report Parsing #16283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/common/rest_api_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
from os import environ
from pathlib import Path
from typing import List, Mapping, Optional
import functools
import json
import operator
import shutil

import requests
Expand Down Expand Up @@ -127,7 +125,11 @@ def paginated_query_api_iterator(self, url: str, params: Mapping[str, str], max_
break

def paginated_query_api(self, url: str, params: Mapping[str, str], max_pages: int = DEFAULT_MAX_PAGES):
return functools.reduce(operator.add, self.paginated_query_api_iterator(url, params, max_pages), [])
return [
item
for page in self.paginated_query_api_iterator(url, params, max_pages)
for item in page
]

def pipelines(
self,
Expand All @@ -151,7 +153,7 @@ def pipelines(
item['trigger']['type'] not in excluded_trigger_types
)
]
if len(matching_items) > 0:
if matching_items:
return matching_items

return []
Expand Down