Skip to content

Rework purity flag setting for constant variables accessed via member access. #16376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rodiazet wants to merge 2 commits into
base: develop
Choose a base branch
from
+23 −8
Draft

Rework purity flag setting for constant variables accessed via member access. #16376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4240753
Move case of constant variable to ContractType case
rodiazet Dec 23, 2025
43069b6
Add removed previously sanity check.
rodiazet Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions libsolidity/analysis/TypeChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3249,13 +3249,26 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
{
if (ContractType const* contractType = dynamic_cast<decltype(contractType)>(typeType->actualType()))
{
// ContractType has only user defined members, so annotation.referencedDeclaration is not NULL.
solAssert(annotation.referencedDeclaration);
annotation.isLValue = annotation.referencedDeclaration->isLValue();
// In case an expression `C.foo`, where `foo` is a function, assign C's purity to `C.foo`.
// This does not allow to assign it to a constant variable, because of different kind.
// Left-hand side of the variable declaration statement never has `Declaration` kind. It is used only to
// mark, that a function containing only such an expression has no effect.
if (
auto const* functionType = dynamic_cast<FunctionType const*>(annotation.type);
functionType &&
functionType->kind() == FunctionType::Kind::Declaration
)
annotation.isPure = *_memberAccess.expression().annotation().isPure;
// In case `Base.value` or `Lib.value` and when `value` is constant, the whole expression is pure.
else if (
auto const* varDecl = dynamic_cast<VariableDeclaration const*>(annotation.referencedDeclaration);
varDecl &&
varDecl->isConstant()
)
annotation.isPure = true;
}
else
annotation.isLValue = false;
Expand Down Expand Up @@ -3322,14 +3335,6 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
annotation.isPure = true;
}

if (
auto const* varDecl = dynamic_cast<VariableDeclaration const*>(annotation.referencedDeclaration);
!annotation.isPure.set() &&
varDecl &&
varDecl->isConstant()
)
annotation.isPure = true;

if (auto magicType = dynamic_cast<MagicType const*>(exprType))
{
if (magicType->kind() == MagicType::Kind::ABI)
Expand Down Expand Up @@ -3409,6 +3414,16 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
if (!annotation.isPure.set())
annotation.isPure = false;

if (
auto const* funcType = dynamic_cast<FunctionType const*>(annotation.type);
funcType &&
funcType->kind() != FunctionType::Kind::Declaration &&
funcType->kind() != FunctionType::Kind::Internal &&
funcType->kind() != FunctionType::Kind::Error &&
funcType->kind() != FunctionType::Kind::Event
)
solAssert(funcType->isPure() == *annotation.isPure);

return false;
}

Expand Down