Skip to content

Fix incorrect shadow warning for variables in non-overlapping scopes #16379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heathdutton wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −1
Open

Fix incorrect shadow warning for variables in non-overlapping scopes #16379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libsolidity/analysis/NameAndTypeResolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,9 @@ void NameAndTypeResolver::warnHomonymDeclarations() const
for (Declaration const* outerDeclaration: outerDeclarations)
{
solAssert(outerDeclaration, "");
if (auto const* varDecl = dynamic_cast<VariableDeclaration const*>(outerDeclaration))
if (varDecl->isLocalVariable() && outerDeclaration->location().start >= innerLocation->start)
continue;
if (dynamic_cast<MagicVariableDeclaration const*>(outerDeclaration))
magicShadowed = true;
else if (!outerDeclaration->isVisibleInContract())
Expand Down
1 change: 0 additions & 1 deletion ...libsolidity/syntaxTests/scoping/double_variable_declaration_disjoint_scope_activation.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,5 @@ contract test {
}
}
// ----
// Warning 2519: (57-63): This declaration shadows an existing declaration.
// Warning 2072: (57-63): Unused local variable.
// Warning 2072: (75-81): Unused local variable.