Added --ease-anticipate-* easings #419
Conversation
…d --ease-squish-* to --ease-elastic-out-* and --ease-elastic-in-out-*
|
|
There was a problem hiding this comment.
very thorough! thank you!
you looked around and found the ancillary areas of usage and examples and made sure it was covered 🤘🏻
I found one type and made a suggestion about it.
Other than that, the tests need updated because there's new props!
- https://github.com/argyleink/open-props/blob/main/test/basic.test.cjs#L7 is now 1622
- https://github.com/argyleink/open-props/blob/main/test/basic.test.cjs#L27 is now 424
breaking change
I fully agree this is a breaking change! I could make a v2 branch and we can adjust this PR to push to that (at which point I can start hacking on v2 changes more), but, we could also do a minor version change to 1.6.0 and put a note in the docsite about the name change? or we could even keep both names around (old squish and elastic) ones, and provide a deprecation notice. thoughts on this? in terms of a breaking change, it's pretty minor, but breaking nonetheless.
Fixed typo from refactor in docsite/index.css as per Adam's comment Co-authored-by: Adam Argyle <[email protected]>
|
Accepted your changes Adam! I also made another commit to adjust the tests. Thanks for catching the typo. As for your discussion of making a v2 branch, I feel it would be nice to give users this additional prop. Why don't we go with your second proposal of making a change to 1.6.0, aliasing |
* version bump * Added --ease-anticipate-* easings (#419) * breaking change: added --ease-elastic-in, renamed --ease-elastic-* and --ease-squish-* to --ease-elastic-out-* and --ease-elastic-in-out-* * Update docsite/index.css Fixed typo from refactor in docsite/index.css as per Adam's comment Co-authored-by: Adam Argyle <[email protected]> * adjusted tests to correspond to additional props we added --------- Co-authored-by: Alex Li <[email protected]> Co-authored-by: Adam Argyle <[email protected]> * document and create fallback * update tests --------- Co-authored-by: Alex Li <[email protected]> Co-authored-by: Alex Li <[email protected]>
breaking change
Added --ease-elastic-in, renamed --ease-elastic-* and --ease-squish-* to --ease-elastic-out-* and --ease-elastic-in-out-* (rename as per Adam's comment). Corresponding changes to docsite were made (adding --ease-elastic-in-* demo box and refactored for the rename).
P.S: First time OSS contributor and new to CSS, sorry it there are any issues w/ my Bezier functions or anything else.