Conversation
WalkthroughThis pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 87: Update the package.json dependency entry for "@arkade-os/sdk" to a
published version: replace the non-existent "0.4.14" with the correct published
version (e.g., "0.4.10") or the intended private registry version; ensure
package.json's dependency string for "@arkade-os/sdk" is valid and matches the
npm registry (or document alternative registry settings) so npm install will
succeed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 87db92a8-ef56-4bd7-8d1d-64c2e2b28fb6
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
🔍 PR Review —
|
| Change | Impact |
|---|---|
@kukks/bitcoin-descriptors → @bitcoinerlab/descriptors-scure 3.1.7 |
Upstream descriptor library swap. The scure variant uses the same @noble/* + @scure/* stack already in the dep tree |
@bitcoinerlab/miniscript 1.4.3 → 2.0.0 |
Major version bump (transitive). Now a hard dep instead of optional |
@noble/curves 2.0.0 removed, 2.0.1 only |
Deduplication — good |
@noble/hashes 2.0.0 removed, 2.0.1 only |
Deduplication — good |
@scure/bip32 2.0.0 removed, 2.0.1 only |
Deduplication — good |
New transitive: lodash.memoize, uint8array-tools, varuint-bitcoin |
Small additions from descriptors-core |
Assessment
✅ Clean bump. The descriptor library migration (@kukks/bitcoin-descriptors → @bitcoinerlab/descriptors-scure) is the significant change here — it's the same underlying crypto primitives (@noble/*, @scure/*) with a different descriptor parsing implementation. The miniscript major version bump (1.x → 2.0) is transitive and shouldn't affect boltz-swap directly since it doesn't use miniscript APIs.
One thing to verify: boltz-swap uses @scure/btc-signer directly alongside the SDK. Confirm the SDK's internal descriptor operations still produce compatible PSBT structures with the btc-signer version pinned here (2.0.1). The lockfile shows they share the same version, so this should be fine.
Cross-repo note: wallet#492 and boltz-swap#106 are also open for the regtest environment migration — no conflicts with this bump.
Summary by CodeRabbit