Skip to content

Upgrade ts-sdk to 0.4.14#112

Merged
pietro909 merged 1 commit intomasterfrom
upgrade-ts-sdk-0.4.14
Mar 31, 2026
Merged

Upgrade ts-sdk to 0.4.14#112
pietro909 merged 1 commit intomasterfrom
upgrade-ts-sdk-0.4.14

Conversation

@pietro909
Copy link
Copy Markdown
Contributor

@pietro909 pietro909 commented Mar 31, 2026

Summary by CodeRabbit

  • Chores
    • Updated SDK dependency to the latest version, which may include bug fixes and improvements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

Walkthrough

This pull request updates the @arkade-os/sdk dependency version in package.json from 0.4.12 to 0.4.14, bringing in bug fixes and improvements from the upstream SDK package.

Changes

Cohort / File(s) Summary
Dependency Version Bump
package.json
Updated @arkade-os/sdk from version 0.4.12 to 0.4.14.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Possibly related PRs

Suggested reviewers

  • bordalix
  • louisinger
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade ts-sdk to 0.4.14' accurately and specifically describes the main change in the pull request, which is upgrading the @arkade-os/sdk dependency from 0.4.12 to 0.4.14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-ts-sdk-0.4.14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 87: Update the package.json dependency entry for "@arkade-os/sdk" to a
published version: replace the non-existent "0.4.14" with the correct published
version (e.g., "0.4.10") or the intended private registry version; ensure
package.json's dependency string for "@arkade-os/sdk" is valid and matches the
npm registry (or document alternative registry settings) so npm install will
succeed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 87db92a8-ef56-4bd7-8d1d-64c2e2b28fb6

📥 Commits

Reviewing files that changed from the base of the PR and between dc09f19 and 036d482.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

@pietro909 pietro909 merged commit 27a1a10 into master Mar 31, 2026
2 checks passed
@arkanaai
Copy link
Copy Markdown

arkanaai bot commented Mar 31, 2026

🔍 PR Review — @arkade-os/sdk 0.4.12 → 0.4.14

Dependency-only bump. No application code changes.

What's in 0.4.14

Per the ts-sdk release notes:

  1. Configurable per-message timeouts (ts-sdk#371) — affects WebSocket/gRPC transport layer
  2. @bitcoinerlab/descriptors-scure 3.1.7 (ts-sdk#392) — replaces @kukks/bitcoin-descriptors

Lockfile analysis

Change Impact
@kukks/bitcoin-descriptors@bitcoinerlab/descriptors-scure 3.1.7 Upstream descriptor library swap. The scure variant uses the same @noble/* + @scure/* stack already in the dep tree
@bitcoinerlab/miniscript 1.4.3 → 2.0.0 Major version bump (transitive). Now a hard dep instead of optional
@noble/curves 2.0.0 removed, 2.0.1 only Deduplication — good
@noble/hashes 2.0.0 removed, 2.0.1 only Deduplication — good
@scure/bip32 2.0.0 removed, 2.0.1 only Deduplication — good
New transitive: lodash.memoize, uint8array-tools, varuint-bitcoin Small additions from descriptors-core

Assessment

Clean bump. The descriptor library migration (@kukks/bitcoin-descriptors@bitcoinerlab/descriptors-scure) is the significant change here — it's the same underlying crypto primitives (@noble/*, @scure/*) with a different descriptor parsing implementation. The miniscript major version bump (1.x → 2.0) is transitive and shouldn't affect boltz-swap directly since it doesn't use miniscript APIs.

One thing to verify: boltz-swap uses @scure/btc-signer directly alongside the SDK. Confirm the SDK's internal descriptor operations still produce compatible PSBT structures with the btc-signer version pinned here (2.0.1). The lockfile shows they share the same version, so this should be fine.

Cross-repo note: wallet#492 and boltz-swap#106 are also open for the regtest environment migration — no conflicts with this bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant