-
Notifications
You must be signed in to change notification settings - Fork 22
feat: use arkade-regtest for regtest environment #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kukks
wants to merge
57
commits into
master
Choose a base branch
from
feat/use-arkade-regtest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
2e5fcfc
chore: bump @kukks/bitcoin-descriptors to 3.2.3
Kukks fac2994
feat: use arkade-regtest submodule for regtest environment
Kukks 437b041
fix: add chmod +x for regtest scripts in CI
Kukks 9d24e0b
fix: update container name and nigiri PATH for arkade-regtest
Kukks c8f2deb
chore: bump arkade-regtest submodule (add delegator)
Kukks 2137f09
fix: update delegator port from 7002 to 7012
Kukks 6f87195
chore: bump arkade-regtest (increase delegator retries)
Kukks 3bef99c
fix: configure arkd for ts-sdk test compatibility
Kukks df75647
chore: bump arkade-regtest (export env vars fix)
Kukks a479f49
chore: bump arkade-regtest (always recreate arkd with env vars)
Kukks f774d10
chore: bump arkade-regtest (add wallet signer key)
Kukks 0b6c0e2
chore: bump arkade-regtest (wallet network + unlocker fix)
Kukks 73ec403
chore: bump arkade-regtest (custom arkd health check)
Kukks aa6c3de
chore: bump arkade-regtest (simpler health check)
Kukks 229d750
chore: bump arkade-regtest (docker exec health check)
Kukks 37030b0
chore: bump arkade-regtest (multi-method health check)
Kukks 06fbc87
chore: bump arkade-regtest (health check debug)
Kukks 0a811d8
chore: bump arkade-regtest (TCP health check)
Kukks 6a15f55
chore: bump arkade-regtest (combined TCP+init health check)
Kukks 183e35f
chore: bump arkade-regtest (admin port health check)
Kukks 3fb08d8
chore: bump arkade-regtest (separate init retry)
Kukks a252896
chore: bump arkade-regtest (longer ark init retries)
Kukks 6ce8a68
fix: update arkade-regtest with chain indexing wait and better diagno…
Kukks ed5a98e
chore: trigger CI
Kukks 6ceaec6
ci: add workflow_dispatch trigger for manual CI runs
Kukks 90ebd76
fix: update arkade-regtest with bitcoin RPC readiness check
Kukks a4415fb
fix: resolve merge conflicts with master (dependency rename)
Kukks 14fcbdc
fix: update arkade-regtest submodule (bitcoin restart after arkd init)
Kukks 7021e4e
fix: update arkade-regtest (nbxplorer sync check before custom arkd)
Kukks d3a91e5
fix: update arkade-regtest (nbxplorer container name, CSV block type)
Kukks ddc85e2
fix: update arkade-regtest (host curl, clean volumes, more retries)
Kukks aad37dd
fix: update arkade-regtest (remove broken nbxplorer check)
Kukks f9a005e
fix: use gocron scheduler for seconds-based VtxoTreeExpiry
Kukks e87381f
fix: use gocron + ALLOW_CSV_BLOCK_TYPE=false for v0.9.0 compat
Kukks 4c040fe
fix: use block scheduler for v0.9.0, update regtest submodule
Kukks d921113
fix: update regtest submodule (GET for wallet seed endpoint)
Kukks dfc814a
fix: update regtest submodule (non-fatal redeem-notes)
Kukks b86cde7
fix: update regtest submodule (timeout for note/redeem-notes)
Kukks a4160a1
fix: update regtest submodule (curl timeouts + mine blocks before set…
Kukks 650c579
fix: update regtest submodule (add ARKD_ROUND_INTERVAL for block sche…
Kukks 64497ea
fix: reduce ARKD_ROUND_INTERVAL to 3 for faster rounds in tests
Kukks 0d0fd6a
fix: update regtest submodule (restart chopsticks after bitcoin restart)
Kukks aeeb212
fix: update regtest submodule with arkd restart after chopsticks
Kukks c600c58
fix: update regtest submodule - move bitcoin config before arkd startup
Kukks f23c260
fix: skip Bitcoin Core restart to prevent nbxplorer connection loss
Kukks 0fe76a3
fix: update regtest submodule — fund server wallet, not client boardi…
Kukks 0fccb81
fix: update regtest — 21-tx server funding for fee estimation
Kukks 5842c35
fix: update regtest — fund Boltz wallet for on-chain swaps
Kukks 0949f5d
fix: update regtest — increase server funding to 21 BTC
Kukks efb1c87
fix: increase VTXO expiry and use fee-aware arkade-regtest
Kukks 4807dff
fix: enable CSV block type for block-based scheduler
Kukks d650973
fix: VTXO expiry must be < 512 for block-based scheduling
Kukks 0e9ce7a
fix: revert VTXO expiry to 20 blocks for ts-sdk
Kukks e632b9f
diag: add extensive logging to failing asset + indexer tests
Kukks ba65ba2
chore: bump regtest (conditional nbxplorer restart)
Kukks fef492d
chore: remove diagnostic logging from e2e tests
Kukks 9d1fad9
chore: point regtest submodule to master after PR merge
Kukks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # ts-sdk arkade-regtest overrides | ||
| ARKD_IMAGE=ghcr.io/arkade-os/arkd:v0.9.0 | ||
| ARKD_WALLET_IMAGE=ghcr.io/arkade-os/arkd-wallet:v0.9.0 | ||
|
|
||
| # Match old ts-sdk docker-compose arkd config | ||
| ARKD_ALLOW_CSV_BLOCK_TYPE=true | ||
| ARKD_VTXO_TREE_EXPIRY=20 | ||
| ARKD_BOARDING_EXIT_DELAY=1024 | ||
|
|
||
| # Zero fees — ts-sdk tests manage fees individually via setFees()/clearFees() | ||
| ARK_OFFCHAIN_INPUT_FEE="0.0" | ||
| ARK_ONCHAIN_INPUT_FEE="0.0" | ||
| ARK_OFFCHAIN_OUTPUT_FEE="0.0" | ||
| ARK_ONCHAIN_OUTPUT_FEE="0.0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| [submodule "regtest"] | ||
| path = regtest | ||
| url = https://github.com/ArkLabsHQ/arkade-regtest.git | ||
| branch = feat/shared-regtest-env-discovery |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 42
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 1787
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 207
🏁 Script executed:
# Read the actual .env.regtest file to get full context cat .env.regtestRepository: arkade-os/ts-sdk
Length of output: 517
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 42
🏁 Script executed:
# Check contents of regtest directory ls -la regtest/Repository: arkade-os/ts-sdk
Length of output: 170
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 388
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 166
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 71
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 3541
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 640
🏁 Script executed:
Repository: arkade-os/ts-sdk
Length of output: 845
Remove quotes from fee environment variables for consistency with other numeric values.
The fee variables use quoted values (
"0.0") while other numeric environment variables in the same file (ARKD_VTXO_TREE_EXPIRY=20,ARKD_BOARDING_EXIT_DELAY=1024) are unquoted. This inconsistency could potentially cause arkd's parser to treat fees as strings rather than numbers, even if the actual value is the same. Standardize by removing the quotes:🧰 Tools
🪛 dotenv-linter (4.0.0)
[warning] 11-11: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
[warning] 12-12: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
[warning] 13-13: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
[warning] 13-13: [UnorderedKey] The ARK_OFFCHAIN_OUTPUT_FEE key should go before the ARK_ONCHAIN_INPUT_FEE key
(UnorderedKey)
[warning] 14-14: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
🤖 Prompt for AI Agents