fix: transaction list UI polish by sahilc0 · Pull Request #555 · arkade-os/wallet

sahilc0 · 2026-04-22T17:58:46Z

Summary

Lighter dividers (dark10 instead of dark20) for subtler visual separation
Remove border on first transaction item (cleaner look below header)
Asset icon now leading (before amount text) for better visual hierarchy
Asset text uses regular weight instead of smaller size
Fix "haptics feedback" typo → "haptic feedback" in settings

Test plan

Verify dividers are lighter but still visible
First transaction row has no top border
Asset transactions show icon before amount text
Settings > General shows "Haptic feedback" (not "Haptics")

🤖 Generated with Claude Code

Summary by CodeRabbit

Style
- Updated transaction list border color for clearer separation
- Improved transaction row layout: vertical centering and no top border on the first item
- Reordered asset info so avatar appears before amounts and refined amount typography
- Removed the "Transaction history" header for a cleaner list view
Bug Fixes
- Corrected haptic feedback label text

- Lighter dividers (dark10 instead of dark20) - Remove border on first transaction item - Asset icon now leading (before amount text) - Asset text uses regular weight instead of smaller size - Fix "haptics feedback" typo → "haptic feedback"

coderabbitai · 2026-04-22T17:58:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d84e16b9-94b3-42dd-b591-c37a4264dbbf

📥 Commits

Reviewing files that changed from the base of the PR and between 5e4bf63 and cf15ca0.

📒 Files selected for processing (1)

src/components/TransactionsList.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/TransactionsList.tsx

Walkthrough

Change TransactionsList row styling and layout: swap border token to --dark10, add optional isFirst to suppress the top border on the first row, center-align row content, move AssetAvatar before amount and apply thin text; also fix SettingsOptions.Haptics enum value to 'haptic feedback'. (≤50 words)

Changes

Cohort / File(s)	Summary
Transaction List Styling & Layout `src/components/TransactionsList.tsx`	Changed border token from `--dark20` → `--dark10`; added optional `isFirst` prop and pass `virtualItem.index === 0` to rows; set `alignItems: 'center'`; remove top border when `isFirst` is true; reordered `AssetAvatar` before amount and applied `thin` text styling; removed "Transaction history" header.
Settings Options `src/lib/types.ts`	Corrected enum value string: `SettingsOptions.Haptics` changed from `'haptics feedback'` → `'haptic feedback'`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Refactor haptics settings #341: Touches the same SettingsOptions.Haptics enum entry; directly related to the enum value change.
minor UI fixes #470: Modifies src/components/TransactionsList.tsx layout/styling; overlaps with row/layout changes here.
fix(ui): top-align tx history rows when assets are present #537: Adjusts TransactionsList row vertical alignment and may conflict with the new alignItems: 'center' and isFirst behavior.

Suggested reviewers

pietro909
bordalix
Kukks

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: transaction list UI polish' directly describes the main change: UI improvements to the transaction list component, which aligns with the primary focus of the changeset (styling adjustments, layout improvements, and header removal).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch wt-tx-list-fixes-20260422

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cloudflare-workers-and-pages · 2026-04-22T17:59:26Z

Deploying wallet-bitcoin with Cloudflare Pages

Latest commit:	`cf15ca0`
Status:	✅ Deploy successful!
Preview URL:	https://d5354a1c.wallet-bitcoin.pages.dev
Branch Preview URL:	https://wt-tx-list-fixes-20260422.wallet-bitcoin.pages.dev

View logs

cloudflare-workers-and-pages · 2026-04-22T18:00:17Z

Deploying wallet-mutinynet with Cloudflare Pages

Latest commit:	`cf15ca0`
Status:	✅ Deploy successful!
Preview URL:	https://deed9a2f.arkade-wallet.pages.dev
Branch Preview URL:	https://wt-tx-list-fixes-20260422.arkade-wallet.pages.dev

View logs

cloudflare-workers-and-pages · 2026-04-22T18:01:05Z

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with Cloudflare Pages

Latest commit:	`cf15ca0`
Status:	✅ Deploy successful!
Preview URL:	https://aabdf779.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL:	https://wt-tx-list-fixes-20260422.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

arkanaai

Arkana Code Review — APPROVE ✅

Pure UI polish + typo fix. No protocol-critical code touched.

Changes reviewed:

src/components/TransactionsList.tsx

Border color dark20 → dark10: cosmetic, fine.
isFirst prop to suppress top border on first row: clean implementation, correctly passed via virtualItem.index === 0.
Asset avatar moved before amount text: layout reorder only.
smaller → thin on asset text: style change only.
Removed <TextLabel>Transaction history</TextLabel> and the wrapping fragment — TextLabel import correctly removed from line 4.
No logic changes, no state changes, no data flow changes.

src/lib/types.ts

SettingsOptions.Haptics value: 'haptics feedback' → 'haptic feedback'. Verified all consumers use the enum reference (SettingsOptions.Haptics), not the string value directly. The string is only used for display/aria labels. Safe typo fix.

bun.lock

New lockfile addition (1264 lines). Not previously tracked. No .gitignore entry for it. Committing lockfiles is correct practice.

Nit (non-blocking):

The bun.lock addition is unrelated to the UI polish. Consider separating lockfile commits from feature changes for cleaner git history, but not a blocker.

No protocol-critical code (VTXOs, signing, forfeit, rounds, exits) is touched. No cross-repo impact — all changes are internal UI components and a display-only enum value.

LGTM.

arkanaai

Arkana Code Review — APPROVE ✅

Pure UI polish + typo fix. No protocol-critical code touched.

Changes reviewed:

src/components/TransactionsList.tsx

Border color dark20 → dark10: cosmetic, fine.
isFirst prop to suppress top border on first row: clean implementation, correctly passed via virtualItem.index === 0.
Asset avatar moved before amount text: layout reorder only.
smaller → thin on asset text: style change only.
Removed <TextLabel>Transaction history</TextLabel> and the wrapping fragment — TextLabel import correctly removed from line 4.
No logic changes, no state changes, no data flow changes.

src/lib/types.ts

SettingsOptions.Haptics value: 'haptics feedback' → 'haptic feedback'. Verified all consumers use the enum reference (SettingsOptions.Haptics), not the string value directly. The string is only used for display/aria labels. Safe typo fix.

bun.lock

New lockfile addition (1264 lines). Not previously tracked. No .gitignore entry for it. Committing lockfiles is correct practice.

Nit (non-blocking):

The bun.lock addition is unrelated to the UI polish. Consider separating lockfile commits from feature changes for cleaner git history, but not a blocker.

No protocol-critical code (VTXOs, signing, forfeit, rounds, exits) is touched. No cross-repo impact — all changes are internal UI components and a display-only enum value.

LGTM.

arkanaai

Arkana Code Review — APPROVE ✅

Iterative review: Only cf15ca07 (merge of master) is new since my last review.

The merge brought master changes into TransactionsList.tsx:

New prettyFiatAmount/prettyFiatHide imports (verified exports exist in format.ts)
asAssets flag for conditional asset display sizing
Updated Right component rendering order for asset transactions
FlexRow between/alignItems='start' props (verified FlexRow.tsx accepts both)

All merge integrations are clean — no conflict markers, no logic regressions, no broken imports. The PR's own changes (border styling, isFirst, haptic typo) remain intact and correct.

No protocol-critical code touched. Ship it.

fix: transaction list UI polish

5e4bf63

- Lighter dividers (dark10 instead of dark20) - Remove border on first transaction item - Asset icon now leading (before amount text) - Asset text uses regular weight instead of smaller size - Fix "haptics feedback" typo → "haptic feedback"

fix: remove transaction history label

2748ad9

sahilc0 requested review from bordalix and pietro909 April 22, 2026 18:08

style: format TransactionsList

58b58b3

arkanaai Bot approved these changes Apr 22, 2026

View reviewed changes

Merge branch 'master' into wt-tx-list-fixes-20260422

cf15ca0

arkanaai Bot approved these changes Apr 23, 2026

View reviewed changes

gringokiwi merged commit 767f515 into master Apr 30, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: transaction list UI polish#555

fix: transaction list UI polish#555
gringokiwi merged 4 commits intomasterfrom
wt-tx-list-fixes-20260422

sahilc0 commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

arkanaai Bot left a comment

Uh oh!

arkanaai Bot left a comment

Uh oh!

arkanaai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sahilc0 commented Apr 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-bitcoin with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying wallet-mutinynet with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with Cloudflare Pages

Uh oh!

arkanaai Bot left a comment

Choose a reason for hiding this comment

Arkana Code Review — APPROVE ✅

Changes reviewed:

Nit (non-blocking):

Uh oh!

arkanaai Bot left a comment

Choose a reason for hiding this comment

Arkana Code Review — APPROVE ✅

Changes reviewed:

Nit (non-blocking):

Uh oh!

arkanaai Bot left a comment

Choose a reason for hiding this comment

Arkana Code Review — APPROVE ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sahilc0 commented Apr 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 22, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 22, 2026 •

edited

Loading