fix branta lint error

[bordalix]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of payment platform logo display in the wallet send form.

[coderabbitai]

Walkthrough

The PR replaces the SDK-exported Payment type with a locally defined BrantaPayment type in the Send Form component, extending it with a required platform_logo_url field to match the component's specific needs.

Changes

Cohort / File(s)	Summary
Payment Type Definition src/screens/Wallet/Send/Form.tsx	Replaces SDK Payment type import with locally defined BrantaPayment type, shaped from V2BrantaClient['addPayment'] return type and extended with required platform_logo_url field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Send tests #218: Also modifies src/screens/Wallet/Send/Form.tsx, adjusting local helpers and state handling alongside this PR's typing changes.
• Branta integration #490: Added Branta integration and introduced the Payment type in the same Send Form file, which this PR now replaces with a local type definition.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'fix branta lint error' is vague and doesn't clearly communicate what specific lint error was fixed or how the code was modified.	Consider a more descriptive title like 'Replace Payment type with BrantaPayment in Form.tsx' to better convey the actual change being made.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix_branta

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cloudflare-workers-and-pages]

Deploying wallet-mutinynet with    Cloudflare Pages

Latest commit:	83523b9
Status:	✅  Deploy successful!
Preview URL:	https://314f17d5.arkade-wallet.pages.dev
Branch Preview URL:	https://fix-branta.arkade-wallet.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with    Cloudflare Pages

Latest commit:	83523b9
Status:	✅  Deploy successful!
Preview URL:	https://ae7ebe48.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL:	https://fix-branta.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

[cloudflare-workers-and-pages]

Deploying wallet-bitcoin with    Cloudflare Pages

Latest commit:	83523b9
Status:	✅  Deploy successful!
Preview URL:	https://f56d8038.wallet-bitcoin.pages.dev
Branch Preview URL:	https://fix-branta.wallet-bitcoin.pages.dev

View logs

[arkanaai]

Review: fix branta lint error

Verdict: APPROVE ✅

Single-file change in src/screens/Wallet/Send/Form.tsx. Replaces the SDK's Payment type (which apparently doesn't match what getPaymentsByQRCode actually returns) with a locally-derived BrantaPayment type inferred from V2BrantaClient['addPayment'].

What changed

1. Removed Payment import from @branta-ops/branta
2. Added local BrantaPayment type using Partial<Awaited<ReturnType<...>>> + platform_logo_url
3. Updated state and callback typing to use BrantaPayment

Analysis

• Not protocol-critical. No VTXO, signing, forfeit, round, or exit path changes. This is purely Branta payment verification UI.
• Type safety is adequate. Partial<...> makes all fields optional, which is fine — the template already guards access: verify_url?.startsWith(...) (line 801), conditional render on platform_logo_url (line 810). brantaPayment.platform (line 799) could render undefined but React handles that gracefully (renders nothing).
• No cross-repo impact. BrantaPayment is file-local, not exported.
• TODO is clear. // TODO: Replace when SDK is accurate — intent to revert to SDK type once upstream fixes their export.
• Runtime behavior unchanged. This is a type-level-only change; no logic modified.

Clean fix. Ship it.

---

Reviewed by Arkana 🔍

[arkanaai]

Review: fix branta lint error

Verdict: APPROVE ✅

Single-file change in src/screens/Wallet/Send/Form.tsx. Replaces the SDK's Payment type (which apparently doesn't match what getPaymentsByQRCode actually returns) with a locally-derived BrantaPayment type inferred from V2BrantaClient['addPayment'].

What changed

1. Removed Payment import from @branta-ops/branta
2. Added local BrantaPayment type using Partial<Awaited<ReturnType<...>>> + platform_logo_url
3. Updated state and callback typing to use BrantaPayment

Analysis

• Not protocol-critical. No VTXO, signing, forfeit, round, or exit path changes. This is purely Branta payment verification UI.
• Type safety is adequate. Partial<...> makes all fields optional, which is fine — the template already guards access: verify_url?.startsWith(...) (line 801), conditional render on platform_logo_url (line 810). brantaPayment.platform (line 799) could render undefined but React handles that gracefully (renders nothing).
• No cross-repo impact. BrantaPayment is file-local, not exported.
• TODO is clear. // TODO: Replace when SDK is accurate — intent to revert to SDK type once upstream fixes their export.
• Runtime behavior unchanged. This is a type-level-only change; no logic modified.

Clean fix. Ship it.

---

Reviewed by Arkana 🔍

[coderabbitai]

🧹 Nitpick comments (1)

src/screens/Wallet/Send/Form.tsx (1)

53-58: Outer Partial<> makes the platform_logo_url extension optional too.

The intersection & { platform_logo_url: string } is inside the Partial<>, so platform_logo_url ends up optional alongside every SDK field. That's actually consistent with how the code uses it (the ?.startsWith(...) and brantaPayment.platform_logo_url ? guards at lines 317 and 817), but it conflicts with the stated intent of "extended with a required platform_logo_url field". If the property is truly meant to be optional, consider making that explicit; if it should be required, lift the extension outside Partial<>.

♻️ Optional refactor (if you want the field to read as explicitly optional)

 // TODO: Replace when SDK is accurate
-type BrantaPayment = Partial<
-  Awaited<ReturnType<V2BrantaClient['addPayment']>>['payment'] & {
-    platform_logo_url: string
-  }
->
+type BrantaPayment = Partial<Awaited<ReturnType<V2BrantaClient['addPayment']>>['payment']> & {
+  platform_logo_url?: string
+}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/screens/Wallet/Send/Form.tsx` around lines 53 - 58, The BrantaPayment
type currently wraps the SDK fields and the added platform_logo_url inside
Partial, making platform_logo_url optional unintentionally; update the type in
Form.tsx so that the platform_logo_url intent is explicit: either move the
intersection outside Partial to require platform_logo_url (e.g., Partial<...> &
{ platform_logo_url: string }) or keep it optional by declaring
platform_logo_url?: string outside/inside as appropriate, and update usages if
needed; target the BrantaPayment type definition near the top of the file.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/screens/Wallet/Send/Form.tsx`:
- Around line 53-58: The BrantaPayment type currently wraps the SDK fields and
the added platform_logo_url inside Partial, making platform_logo_url optional
unintentionally; update the type in Form.tsx so that the platform_logo_url
intent is explicit: either move the intersection outside Partial to require
platform_logo_url (e.g., Partial<...> & { platform_logo_url: string }) or keep
it optional by declaring platform_logo_url?: string outside/inside as
appropriate, and update usages if needed; target the BrantaPayment type
definition near the top of the file.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27c1b423-d1a0-46f6-b1a1-04869bbfa548

📥 Commits

Reviewing files that changed from the base of the PR and between 12d99b2 and 83523b9.

📒 Files selected for processing (1)

• src/screens/Wallet/Send/Form.tsx