Skip to content
This repository has been archived by the owner on Dec 16, 2019. It is now read-only.

[WIP] ENH: RESTful API to serve the data format #4 #9

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

jblemoine
Copy link
Contributor

@jblemoine jblemoine commented Nov 5, 2018

Description

This is a RESTful API to serve the data format.
Implementation of #4

Usage

Store

You must send a post request to: http://localhost:5000/store
The body of your request must match the following template

{
"output_format": "json",
"fhir_resource_name": "patient"
}

Mapping

You must send a post request to: http://localhost:5000/mapping
The body of your request must match the following template

{
"output_format": "json",
"fhir_resource_name": "patient"
"database": "CW"
}

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if any
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective, if unittests are enabled
  • New and existing unit tests pass locally with my changes, if any

@jblemoine jblemoine changed the title [WIP] ENH: Add unittest suite with pytest (#4) [WIP] ENH: Add unittest suite with pytest #4 Nov 5, 2018
@jblemoine jblemoine changed the title [WIP] ENH: Add unittest suite with pytest #4 [WIP] ENH: RESTful API to serve the data format #4 Nov 5, 2018
alexisthual
alexisthual previously approved these changes Nov 5, 2018
Copy link
Contributor

@alexisthual alexisthual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR, thanks!
There are a couple of lines we need to check before merging, but after that I think we are good to go!

api/common/utils.py Show resolved Hide resolved
api/resources/resources.py Show resolved Hide resolved
api/resources/resources.py Outdated Show resolved Hide resolved
api/resources/resources.py Outdated Show resolved Hide resolved
@jblemoine jblemoine dismissed stale reviews from alexisthual via 45d0a1a November 6, 2018 09:47
Copy link
Contributor

@alexisthual alexisthual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

@alexisthual alexisthual merged commit ac67d0d into master Nov 6, 2018
@alexisthual alexisthual deleted the jblemoine_api branch November 6, 2018 10:21
@alexisthual alexisthual restored the jblemoine_api branch November 6, 2018 10:25
@jblemoine jblemoine mentioned this pull request Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants