WIP: Add support for running with a remote Armada server #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are to allow running an armada-spark client against a remote (i.e. non-localhost) Armada cluster server. Signed-off-by: Rich Scott <[email protected]>
Also, fixes in TestOrchestrator for running against a remote Armada instance, and run the tests directly, instead of using a Docker container on the client. Signed-off-by: Rich Scott <[email protected]>
It will soon be used by ArmadaClientApplication. Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
…artup tasks Signed-off-by: Rich Scott <[email protected]>
…rver. Signed-off-by: Rich Scott <[email protected]>
GeorgeJahad
reviewed
Nov 22, 2025
Comment on lines
+102
to
+103
| of `kubectl config view`. These files can be left in this directory. | ||
|
|
Collaborator
There was a problem hiding this comment.
Should e2e/*crt be in .gitignore?
GeorgeJahad
reviewed
Nov 22, 2025
scripts/dev-e2e.sh
Outdated
|
|
||
| TMPDIR="$scripts/.tmp" "$AOHOME/bin/tooling/kind" load docker-image "$IMAGE_NAME" --name armada 2>&1 \ | ||
| | log_group "Loading Docker image $IMAGE_NAME into Armada cluster"; | ||
| if [ "$ARMADA_MASTER" = "localhost" ] ; then |
Collaborator
There was a problem hiding this comment.
ARMADA_MASTER is never just "localhost" is it?
usually something like: "armada://localhost:30002"
GeorgeJahad
reviewed
Nov 22, 2025
| Seq(armadactlCmd) ++ subCommand.split(" ") ++ Seq("--armadaUrl", armadaUrl) | ||
| // armadactl command expects the server address to be of the form | ||
| // <hostname-or-IP>:<port> with no pseudo-protocol prefix | ||
| var armadactlUrl = armadaUrl.replaceFirst("^armada://", "") |
GeorgeJahad
reviewed
Nov 22, 2025
| package org.apache.spark.deploy.armada.e2e | ||
|
|
||
| import io.fabric8.kubernetes.api.model.Pod | ||
| import org.apache.spark.deploy.armada.K8sClient |
GeorgeJahad
reviewed
Nov 22, 2025
| val dockerCommand = buildDockerCommand( | ||
| val runTestCommand = buildRunTestCommand( | ||
| config.imageName, | ||
| volumeMounts, |
Collaborator
There was a problem hiding this comment.
why was this removed?
GeorgeJahad
reviewed
Nov 22, 2025
| lookoutUrl: String, | ||
| pythonScript: Option[String] | ||
| ): Seq[String] = { | ||
| val sparkRepoCopy = ".spark-3.5.5" |
GeorgeJahad
reviewed
Nov 22, 2025
|
|
||
| val classPathEntries: Seq[String] = Seq( | ||
| ".", | ||
| s"${sparkRepoCopy}/assembly/target/scala-2.13/jars/*", |
Collaborator
|
Running with: no longer seems to work: |
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Get the first external interface IP address and use in Kind configuration for allowing external K8S/Armada API access. Add protective quotes around TLS vars in dev-e2e.sh, per shellcheck. Use `realpath` for getting reliable full pathnames. Signed-off-by: Rich Scott <[email protected]>
Use better pattern checks for verifying if Armada master is localhost; remove quote wrapper around tls_args, so Maven doesn't error on a "" target. Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Signed-off-by: Rich Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add support for running a Spark client against a remote Armada server (as opposed to both being on localhost). This has been developed and tested on a macOS system as the Spark client with an Ubuntu Linux server running Armada (on top of a
kindk8s cluster).See updates to the
README.mdfor the steps to use this.Change Details:
README.mddetailing on how to get the cert files, defineARMADA_MASTERinscripts/config.sh, etc..spark-3.5.5).Changes to have
submitArmadaSpark.shwork with a possibly-remote Armada server, just as thedev-e2e.shlogic, are not yet included in this PR, but will be coming soon.