Skip to content

Conversation

@DevTKSS
Copy link
Contributor

@DevTKSS DevTKSS commented Mar 16, 2025

there has been no style matching Visual Studio 2019 code styling used by csharp application development
expecting the color values in ITheme to be Hex code, matched the RGB Colors with google ColorPicker to get those values
maybe this style does mainly apply generally, only very few are only Lang specific
the cloned repository did not contain any executable so I was unable to test it locally

@armhil
Copy link
Owner

armhil commented May 18, 2025

Finally - add the style to the index.ts file please. @DevTKSS

@DevTKSS
Copy link
Contributor Author

DevTKSS commented May 18, 2025

@armhil sorry missed that one. Added commit, are there future things required?

@armhil
Copy link
Owner

armhil commented May 24, 2025

@DevTKSS a few more pls, I'll merge the pkg and bump the app's reference once you fix those.

@DevTKSS DevTKSS requested a review from armhil May 31, 2025 16:24
@armhil armhil merged commit 6cf2a0a into armhil:main May 31, 2025
1 check failed
@armhil
Copy link
Owner

armhil commented May 31, 2025

@DevTKSS your changes are merged, should be deployed already. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants