-
Notifications
You must be signed in to change notification settings - Fork 4
Modernize the codebase #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not allowed to apply clang-format, so do it Yourself pls or let me push into PR.
I am happy to help. Should I format the changed files only and run |
nvm Ill reformat code later. |
could You enable allow edit for me in PR, it is in Your options |
sure thx. |
I suspect the compiler would rant about it? I might got carried away from clang-tidy's proposals and best practices. Whatever, I can remove them, it's not like it's the improvement or something. |
This PR applies the
default
keywords to empty dtors,Q_DISABLE_COPY_MOVE
macro to specifically delete any move or copy operation, const qualifies some variables and functions etc.