Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mousetrap reference #509

Closed
wants to merge 3 commits into from
Closed

Conversation

getkloudi
Copy link

Updated mousetrap reference with a publically hosted folk of mousetrap by kloudi-tech where useCapture has been exposed with a default value of true.

This should close Issue #455

@asabaylus
Copy link
Owner

asabaylus commented Sep 2, 2020

Thanks but I noticed this change updates to a fork of mousetrap. Can you open a PR to support this change with mousetrap upstream?

@codeclimate
Copy link

codeclimate bot commented Sep 2, 2020

Code Climate has analyzed commit f525b38 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@nitishMehrotra
Copy link

@asabaylus There has been PR in mousetrap that is open since 2017 for this change.

ccampbell/mousetrap#400

It doesn't seem like it will get merge. Hence I started maintaining a separate folk.

@asabaylus
Copy link
Owner

@kloudi-tech thanks I’ll give him a few days to reply to my comment on the PR ccampbell/mousetrap#400 (comment)

If no response are you planning to maintain mousetrap? Possibly Craig would like someone to maintain

@nitishMehrotra
Copy link

I'll be maintaining the folk that we have at @kloudi-tech (https://github.com/kloudi-tech/mousetrap)

Majorly making sure that the upstreams doesn't have any conflict with the changes that we have made around useCapture event.

@asabaylus asabaylus self-assigned this Oct 6, 2020
@asabaylus
Copy link
Owner

@nitishMehrotra please reach out to @ccampbell about taking on long term maintenance of mousetrap.js. It seems like the repo has fallen out of maintenance, he may be ready to turn it over. I don't think introducing a dependency on a forked repo is good long term idea as NPM exists for some very good reasons

@asabaylus asabaylus closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants