Skip to content

Conversation

@vpowler
Copy link
Contributor

@vpowler vpowler commented Aug 31, 2021

Checklist:

  • Code follows the style guidelines
  • Documentation updated
  • Corner cases evaluated and handled
  • Automatic tests added/update
  • Automatic tests pass
  • Software runs (locally or hosted)
  • Sanity check passed
  • Self-review passed

@vpowler vpowler changed the title add PrivateKeyRetriever() to ambrosus-node add PrivateKeyRetriever to ambrosus-node Aug 31, 2021
@vitalii427
Copy link
Member

vitalii427 commented Sep 3, 2021

in PrivateKeyRetriever:
private serviceUrl = 'http://172.18.0.2:3000';

Should it be hardcoded url?

@Jerome2506
Copy link

@AndrewAR2 @vitalii427 any chance of reviewing this so we can get this security issue out of the way on our nodes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants