avoid duplicated session when indexing multiple URLs#397
Merged
asciimoo merged 1 commit intoasciimoo:masterfrom May 5, 2026
Merged
avoid duplicated session when indexing multiple URLs#397asciimoo merged 1 commit intoasciimoo:masterfrom
asciimoo merged 1 commit intoasciimoo:masterfrom
Conversation
Each call creates a brand-new crawler (WebSocket connection + session.new + session.end + close) what is very wasteful for bidi. => create the crawler once before the loop and pass it into indexURL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #396
but a separated diff/PR won't hurt.
indexURL() is called per-URL with plain
index URLa URLb.Each call creates a brand-new crawler (WebSocket connection + session.new + session.end + close) what is very wasteful for bidi.
=> create the crawler once before the loop and pass it into indexURL