[enh] Safari support - initial proof of concept#46
Draft
ellieayla wants to merge 1 commit intoasciimoo:masterfrom
Draft
[enh] Safari support - initial proof of concept#46ellieayla wants to merge 1 commit intoasciimoo:masterfrom
ellieayla wants to merge 1 commit intoasciimoo:masterfrom
Conversation
The chrome manifest v3 can be converted automatically to a Safari Web Extention with safari-web-extension-packager, though it uses default icons and description. Effort is needed to package it up pretty. The safari web extension appears to have a similar behaviour to firefox, with the Origin url containing a UUID unique to the installation.
Author
|
(Writing the safari extension into |
Open
asciimoo
force-pushed
the
master
branch
4 times, most recently
from
c97e843 to
2ab8377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chrome manifest v3 can be converted automatically to a Safari Web Extention with
safari-web-extension-packager, though it uses default icons and description. Effort is needed to package it up pretty. Safari doingfetch()demands CORS headers on thePOST /add, and a pre-flightOPTIONS /addrequest. Safari web extensions appear to have a similar behaviour to Firefox, with theOriginheader url containing a UUID unique to the installation.Commit a44a471 is a minimal change to implement support, hopefully to serve as the basis for a proper implementation.
Draft: this is likely not the best way to add CORS headers, this PR is just a POC to demonstrate the possibility.