Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reorganization in #480 broke a few time formats since I missed that in the time schema in addition to the
oneOfinbase_format:asdf-standard/resources/schemas/stsci.edu/asdf/time/time-1.4.0.yaml
Lines 239 to 241 in 92bd63c
there is an exclusive consideration of only the formats listed in
formatinformat:asdf-standard/resources/schemas/stsci.edu/asdf/time/time-1.4.0.yaml
Line 233 in 92bd63c
This fixes the broken formats (cxcsec, galexsec, unix_tai) by moving them from
other_formattoformat.This PR is tested in astropy/asdf-astropy#270 (by setting the asdf-standard pin in that PR to this PR). I will open an issue to discuss moving these "astronomy" schemas to asdf-astropy since this PR highlights the problematic relationship of these two packages (asdf-standard has the astronmy schemas but can't test them without asdf-astropy which needs the schemas to implement support). The "asdf-standard" downstream failure in that PR is another sign of the mess that is these two packages (the job is testing asdf-standard main after install the source branch for this PR).