fix(navigation): support quirky case for snacks.nvim#140
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Snacks.nvim-specific wrapper to improve tmux.nvim navigation behavior when Snacks’ custom window engine is in use (notably for snacks_explorer), aligning border/float detection with Snacks’ internal layout state.
Changes:
- Introduce
tmux.wrapper.snacksto query focused Snacks picker, infer float vs tiled, and map picker position to Neovim directions. - Update
tmux.wrapper.nvimborder and float detection to defer to the focused Snacks picker when present.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lua/tmux/wrapper/snacks.lua | New wrapper for interacting with Snacks picker state (focus, float/tiled inference, position mapping). |
| lua/tmux/wrapper/nvim.lua | Uses the Snacks wrapper to override border/float detection when a Snacks picker is focused. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7b8689a to
5ca93d7
Compare
|
heho, ty for the pr. king regards |
aserowy
left a comment
There was a problem hiding this comment.
Heho,
it would be awesome if you could add tests for snacks behavior as well. Besides tests, pr looks good.
Just out of interest: did you tested it with and without snacks?
kind regards
Alexander
|
Hi, thanks Added tests (not without LLM help). Also tested manually. With snacks everything works as expected (snacks pickers correctly recognized as floating or tiled windows and navigation and resize work correctly). |
aserowy
left a comment
There was a problem hiding this comment.
heho,
nice. llm produced code (if not sloppy) if completly ok. One picky thing though. remove all comments inside tests, because they are redundant. -- abc above describe("abc..") will age badly.
and please commit normally. thus, i can check what changed only and do not have to review everything again, and again, and :D
kind regards and thx for your help
Alexander
|
Thanks, removed redundant comments. I kept only those which actually explain code. I am not sure what do you mean by "committing normally", probably by committing only diff? Also, |
Addressing
#133
folke/snacks.nvim#1802