New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate inputs larger than context window instead of crashing #9

Draft

ochafik wants to merge 1 commit into asg017:main from ochafik:truncate

Contributor

ochafik commented Nov 17, 2024 •

edited

Loading

This should "fix" #7

Not sure this is doing the right thing tbh, feedback welcome:

Currently silently truncating the input. Making truncation optional (and exploding if the option isn't set) runs the risk of most people never using the option and randomly exploding when they finally use larger inputs (in prod).
Aligned n_batch = n_ubatch = n_ctx to avoid crashes in llama.cpp. Possibly very inefficient? Also, default to the model's n_ctx_train.

Tested w/ all-MiniLM-L6-v2.e4ce9877.q8_0.gguf & nomic-embed-text-v1.5.Q8_0.gguf.


          Truncate inputs larger than context window instead of crashing

0bc6cb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet