Fix for musl compile #199
Open
Fix for musl compile #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm the build fails (on Alpine) without this patch and succeeds with it. The changes look reasonable as well (to me, an outsider). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failed while compiling in Alpine in docker.
Type redefinitions.
Figured this might be a better way to conditionally check for the presence of a compliant C library (but I might be wrong).
Also made some small changes to
scripts/vendor.shsince my bash isn't in that location and to my understanding this is the expected way to use the user's bash, and I got an error on theunzip -dline and as far as I'm concerned that didn't do anything meaningful, but that might just be an indication of a different bug. For example you might have meant to dounzip sqlite-amalgamation.zip -d sqlite-amalgamation-3450300or something like that, I honestly didn't bother with it too much.Obviously feel free to correct the changes or close the pull request.